Notification queue and a lot of other improvements #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed #89 Co-authored-by: Thiemo Hoffmann <[email protected]>
Feature/new notification queue
* feat: Notification queues fixed #89 by @theimo1221 * Removal of events and compliance to tests * Two PlayNotification Calls with 2nd having immediate resolve * Two PlayNotification Calls with First Reolving Promise after 2nd * Implement general Timeout functionality within PlayNotification and extend tests * Revert changes to "returns false when not playing" * Move new tests to seperate describe Block * Add individual Timeout for specific queue items plus Test * Clear specific timeout after it being played * chore: Lint errors * chore: Second TTS method * chore: Fixing debug style * chore: Fixing tests Not merged: * ~~Always trigger "STOPPED" event~~ Co-authored-by: Thiemo <[email protected]>
* export SonosEventListener Co-authored-by: H. Klages <[email protected]>
added Invisible to interface and parse method (#124) Co-authored-by: H. Klages <[email protected]>
Improved local documentation loading
Event errors and invisible bug
Pull Request Test Coverage Report for Build 653848679
💛 - Coveralls |
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification queue and a lot of other improvements
Description
This PR will release a new version of sonos-ts. The most notable it the notification queue we made 2 implementations see this issue, and want your opinion about which one is best.
Also Invisible is now parsed correctly and you can subscribe for event subscriptions errors.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.
💔 Thank you!