Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of tests #154

Merged
merged 7 commits into from
Jan 8, 2022
Merged

A lot of tests #154

merged 7 commits into from
Jan 8, 2022

Conversation

svrooij
Copy link
Owner

@svrooij svrooij commented Jan 8, 2022

Testing is fun

Description

  • This library was not having a great code coverage. I tried to get the code coverage higher.
  • This PR also removed the second notification code from the Sonos Device class. It will only be loaded if either PlayNotificationTwo(...) or PlayTtsTwo(...) is called. (Beta test and vote: Notification queue #119)
  • Support for Neural voices (Neural voices support  #146)

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • Check you add tests for added code.

💔 Thank you!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1671675789

  • 161 of 207 (77.78%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.3%) to 81.464%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sonos-device.ts 5 6 83.33%
src/sonos-notification-two.ts 152 197 77.16%
Totals Coverage Status
Change from base Build 1667059904: 3.3%
Covered Lines: 1622
Relevant Lines: 1948

💛 - Coveralls

@svrooij svrooij merged commit 9eec889 into beta Jan 8, 2022
@github-actions
Copy link

github-actions bot commented Jan 8, 2022

🎉 This PR is included in version 2.5.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@svrooij svrooij deleted the feature/tests-22 branch June 16, 2022 13:13
@github-actions
Copy link

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants