Skip to content

Commit

Permalink
Merge pull request #18 from swsnr/address-ego-review
Browse files Browse the repository at this point in the history
Address EGO review
  • Loading branch information
swsnr authored Nov 16, 2023
2 parents 3978829 + 22ea342 commit 3ec2d2f
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 0 deletions.
23 changes: 23 additions & 0 deletions .eslintrc.dist.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Liniting rules to fix up JS formatting for EGO review.
module.exports = {
extends: [],
parserOptions: {
ecmaVersion: 2022,
sourceType: "module",
},
// Any inline comments in the generated JS code refer to the original typescript,
// so let's ignore all of them
noInlineConfig: true,
rules: {
"lines-between-class-members": ["error", "always"],
"padding-line-between-statements": [
"error",
{ blankLine: "always", prev: "*", next: "class" },
{ blankLine: "always", prev: "*", next: "function" },
{ blankLine: "always", prev: "*", next: "return" },
{ blankLine: "always", prev: "*", next: "export" },
{ blankLine: "always", prev: "*", next: "multiline-const" },
],
},
ignorePatterns: [],
};
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ dist: compile
cp -t ./build/ui $(UIDEFS)
cp -t ./build/lib/vendor/saxes ./src/lib/vendor/saxes/README.md
cp -t ./build/lib/vendor/xmlchars ./src/lib/vendor/xmlchars/README.md
npm run dist:format
gnome-extensions pack --force --out-dir dist build \
--podir=../po --extra-source=../metadata.json \
--extra-source=ui --extra-source=lib \
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"scripts": {
"generate:gir-types": "ts-for-gir generate",
"compile": "tsc --build tsconfig.json",
"dist:format": "eslint --no-eslintrc --config .eslintrc.dist.cjs --quiet --fix build/",
"check:types": "tsc --build tsconfig.types.json",
"lint": "eslint .",
"format": "prettier ."
Expand Down

0 comments on commit 3ec2d2f

Please sign in to comment.