Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finnish translation added #82

Open
wants to merge 11 commits into
base: sources
Choose a base branch
from
Open

Finnish translation added #82

wants to merge 11 commits into from

Conversation

jremes-foss
Copy link

Finnish translation added to sympy.github.com site. All strings translated.

If there is anything else regarding this, please let me know.

Thank you.

@@ -11,3 +11,4 @@ msgfmt ru.po -o ru.mo
msgfmt zh.po -o zh.mo
msgfmt es.po -o es.mo
msgfmt nl.po -o nl.mo
msgfmt fi.po -o fi.mo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to commit the fi.po file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for notification, I'll add it now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's sorted out now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@certik
Copy link
Member

certik commented Nov 4, 2015

@pv, would you mind quickly reviewing the Finnish translation (to make sure it's high enough quality so that we can merge it)? It's just the fi.po file: https://github.com/Newman101/sympy.github.com/blob/3046d8bbc689cea12cfbfb25ba81357d4f08960a/i18n/fi.po, everything else is auto generated.
That would be a big help, as I don't speak Finnish, so I can't review it myself.

avustaa:
<ul>
<li>
Mikäli kirjoitit jotakin kiinnostavaa SymPy-ohjelmistolla, ole hyvä ja lähetä meille patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would very much like to see 'patch' translated. For example, 'korjaustiedosto' (or sometimes just 'korjaus').

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I thought that. How ever, "korjaustiedosto" in general tends to mean (literally translated) "a bug fix file". Patches can be new features or code maintenance as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if this is a non-issue, I can translate the term directly.

@jremes-foss
Copy link
Author

Hi. As per request, I changed word "patch" to "korjaustiedosto" which is more accurate translation.

@certik
Copy link
Member

certik commented Nov 4, 2015

Thanks @jksuom. Is there anything else?

<div class="inner">
<p class="first">
Paras tapa on lähettää meille pull request
<a href="http://github.com/sympy/sympy">sympy/sympy</a> repositoryyn.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to find some translations for 'pull request' and 'repository'?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll translate these as soon as I can, probably tomorrow morning

Repository = säilytyspaikka? varasto? repositorio?
Pull request = vetopyyntö?

Most of the sources I've checked are using English terms directly and there are no standard translations for these. If you have any recommendations, please let me know.

@jksuom
Copy link
Member

jksuom commented Nov 4, 2015

Another possible translation for 'patch' could be 'muutostiedosto' (muutos = change). That would cover about everything, additions, deletions, and fixes. (Though patches often are thought of as fixes (korjaus = fix).)

@jremes-foss
Copy link
Author

Most suggestions are now covered. Only issue is fi/features.html, line 146. This entry is not found in the .po file.


#: templates/features.html:93
msgid "It uses extended Risch-Norman heuristic"
msgstr "Se käyttää laajennettua Risch-Norman - heuristiikkaa"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and elsewhere, note grammar for space before/after dash: Risch-Norman-heuristiikka, Planet Sympy -blogi

<li><strong>Sijoitus:</strong> <a href="http://www.sympygamma.com/input/?i=%28exp%28x%29+%2F+%281+%2B+exp%282x%29%29%29.subs%28exp%28x%29%2C+u%29">esimerkki</a></li>
<li><strong>Numerot:</strong>

<a href="http://www.sympygamma.com/input/?i=100%21">mielivaltaisen tarkat kokonaisluvut</a>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something like "rajoittamattomat kokonaisluvut" could be a better description for these numbers (instead of "mielivaltaisen tarkat" as integers are always exact).

<li><strong>Summat</strong></li>
<li><strong>Tulot</strong></li>
<li><strong>Lukuteoria:</strong> alkulukujen generointi, alkulukutestit, kokonaislukuhajotelmat, diofantoksen yhtälöt...</li>
<li><strong>Loogiset lauseet</strong></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local logicians use the term "lause" in a rather strict sense to denote logical formulas with no free variables. They would use "kaava" (formula) for the general case. My personal favourite is "lauseke" (i.e. "Loogiset lausekkeet").

@jksuom
Copy link
Member

jksuom commented Nov 5, 2015

I think that was about all I could suggest. It looks good to me now.

@certik
Copy link
Member

certik commented Nov 5, 2015

@pv and @jksuom thanks a lot for reviewing this!

@Newman101 let me know when this is ready to be merged.

@jremes-foss
Copy link
Author

Ok, last issue has been fixed - I added the missing string to .po file. I think this can be merged now.

@certik
Copy link
Member

certik commented Nov 10, 2015

Thanks! Don't you have to regenerate the files when the po file changes?

@jremes-foss
Copy link
Author

I think I did, but apparently I didn't. Thank you for notifying - I'll re-generate the pages and commit the changes.

@jremes-foss
Copy link
Author

Ok, looks like the last change in .po file was not actually reflected in the web pages. This is why the pages were not committed because there were no changes to commit.

@jremes-foss
Copy link
Author

I'll need to investigate why this happens.

@jremes-foss
Copy link
Author

Looks like the generate script discards all the manually added entries. So I need to investigate whether msgmerge would actually have any effect.

http://stackoverflow.com/questions/7680021/how-to-add-a-new-string-to-a-po-file-w-a-po-editor

@jremes-foss
Copy link
Author

I tried merging it with msgmerge but that did not help either. Attempted to update the string from the sympy.org.pot file and update the po but that was a failure as well. Any other good ideas? Looks like everything I try to do ends up to dead end.

@jremes-foss
Copy link
Author

There is something dodgy here. "Permutation Groups" refers to line features.html:124, but in reality it is in features.html:146. Also, the colon is in the web page but not in the translation file.

@jremes-foss
Copy link
Author

The question follows: Why "Permutation Groups" got translated but "Polyhedral, Rubik, Symmetric, ..." didn't? After all, they are both supposed to be on the same line.

@jremes-foss
Copy link
Author

This might be an issue on other localizations as well.

@certik
Copy link
Member

certik commented Nov 10, 2015

Sorry for the problems. Did you run ./extract_i18n_text to create the initial template? That one should be correct and correspond to the current sources. Then you just merge it with your current translation.

@jremes-foss
Copy link
Author

I am fairly certain I did, but I can re-attempt that tomorrow morning.

@jremes-foss
Copy link
Author

Still investigating the issue with that last problematic string. Is any of the languages fully translated and functional?

@asmeurer asmeurer changed the base branch from master to sources August 4, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants