Add benchmarks for GCD when input is Gaussian Integer #97

1e9abhi1e10 · 2023-08-26T02:14:43Z

This PR adds the benchmarks for the subresultants PRS method.
Related Issue:
#88

1e9abhi1e10 · 2023-08-26T02:21:09Z

@oscarbenjamin These errors occurs, Do We need to change these?

asv run --config asv.conf.actions.json
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/sympy/sympy_benchmarks/actions/runs/5982262043/job/16231134344?pr=97#step:6:3).10.12/x6[4](https://github.com/sympy/sympy_benchmarks/actions/runs/5982262043/job/16231134344?pr=97#step:6:4)
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.12/x[6](https://github.com/sympy/sympy_benchmarks/actions/runs/5982262043/job/16231134344?pr=97#step:6:6)4/lib
Couldn't load asv.plugins.mamba because
No module named 'mamba'
Couldn't load asv.plugins.virtualenv because
No module named 'packaging'
· Unknown environment type 'virtualenv'
· No environments selected
Error: Process completed with exit code 1.

oscarbenjamin · 2023-08-28T08:26:30Z

These errors occurs, Do We need to change these?

This is because of the new asv release. I'm not sure if this is fixed now.

oscarbenjamin · 2023-08-28T08:30:19Z

Looks like it still fails.

benchmarks/polys.py

oscarbenjamin · 2023-09-12T11:07:18Z

The domain should just be returned by the make_poly function like:

return f, g, d, syms, ZZ

benchmarks/polys.py

oscarbenjamin · 2023-09-14T13:41:46Z

benchmarks/polys.py

    def make_poly(self, n):
-        x, y1, y2, y3, y4, y5, y6 = syms =  symbols("x y1 y2 y3 y4 y5 y6")
+        x, y1, y2, y3, y4, y5 = syms =  symbols("x y1 y2 y3 y4 y5")

        d = (-x + I*y1)*n

-        f = ((-I*(x)**4 - (x)**3 + I*(x)**2 + (x) + -I*(y2 + 1) - y1*(y3 + 1) -
-            2*y1*y2 - 5*y1*(y2 + 1) - y1*(y3 + 1) -
-            I*y4 + I*y6 + -y1*(y2 + 1) - 3*y1*y3 - y1*(y3 + 1) - I*y5 -
-            2*y1*y2 - 7*y1*(y2 + 1) - 3*y1*y3 - 5*y1*(y3 + 1) - I*(y4 + y5) -
-            y1*y2 - 2*y1*(y2 + 1) - y1*y3 - 3*y1*(y3 + 1) - I*(-y4 + y5) +
-            y1*(y2 + 1) + -y1*y2 - 5*y1*y3 - y1*(y3 + 1) - I*y5 + -I*y6 -
-            3*y1*(y2 + 1) - y1*y3 - 7*y1*(y3 + 1) + I*y5 + -y1*y2 + y1*(y3 + 1)
-            + 5*y1*(y3 + 1) + -y1*y2 - y1*(y2 + 1) - y1*y3 + y1*y2 + y1*y3 +
-            7*y1*(y3 + 1) + y1*(y2 + 1) + y1*y3)*d)
-
-        g = ((-I*(x)**4 - (x)**3 + I*(x)**2 + (x) + -I*(y2 + 1) - y1*(y3 + 1) -
-            7*y1*y2 - y1*(y2 + 1) - y1*(y3 + 1) -
-            I*y4 + I*y6 - y1*(y2 + 1) - 3*y1*y3 - y1*(y3 + 1) - I*y5 -
-            y1*y2 - 7*y1*(y2 + 1) - 5*y1*y3 - 2*y1*(y3 + 1) - I*(y4 + y5) -
-            3*y1*y2 - 5*y1*(y2 + 1) - 9*y1*y3 - 7*y1*(y3 + 1) -
-            I*(-y4 + y5) + y1*(y2 + 1) + -y1*y2 - y1*y3 - y1*(y3 + 1) -
-            I*y5 + -I*y6 + -y1*(y2 + 1) - y1*y3 - y1*(y3 + 1) + I*y5 - 3*y1*y2
-            + y1*(y3 + 1) + y1*(y3 + 1) + -y1*y2 - y1*(y2 + 1) - y1*y3 +
-            y1*y2 + y1*y3 + y1*(y3 + 1) + y1*(y2 + 1) + y1*y3)*d)
+        f = (-I*x**n - 2*y1*y3 - I*(-y2 + n) - I*(y4 + y5))*d

-        return f, g, d, syms, ZZ_I
+        g = (-I*x**(n + 1) - 2*y1*(y3 + n) - I*(-y2 + n + 1) - I*(y4 + y5))*d

+        return f, g, d, syms, ZZ_I


Why has the example been changed?

In the revised example, I identified duplicate terms, and when I simplified the expression, it resulted in a shorter and more concise form

oscarbenjamin · 2023-09-14T13:43:29Z

Why is x being passed here:

sympy_benchmarks/benchmarks/polys.py

Line 325 in 6aac380

expected_gcd = gcd(f, g, x)

Add benchmarks for GCD when input is Gaussian Integer

c27a9cf

oscarbenjamin closed this Aug 28, 2023

oscarbenjamin reopened this Aug 28, 2023

1e9abhi1e10 closed this Sep 2, 2023

1e9abhi1e10 reopened this Sep 2, 2023

1e9abhi1e10 closed this Sep 10, 2023

1e9abhi1e10 reopened this Sep 10, 2023

oscarbenjamin reviewed Sep 10, 2023

View reviewed changes