-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Better way to link to old docs at docs.sympy.org #19
base: gh-pages
Are you sure you want to change the base?
Conversation
@asmeurer that's working fine in all version except |
What about the generate_indices script? |
I also see the issue with 0.6.7. |
As long as we're using Javascript can we make a popup menu? The only really important ones are |
@asmeurer i am working on this. |
i read |
Regarding 0.6.7, I'm guessing there's a bug in your script, perhaps due to the fact that 0.6.7 is the first entry in the file. |
@asmeurer i added this type of |
@asmeurer that's looks good ? |
I would use a different color from yellow (see https://github.com/sympy/sympy-web-static#sympys-website-design for the pallet we use), but otherwise yes. |
@asmeurer that's looks good ? |
var res = elem.split(":"); | ||
if(res[0] == "0.7.6.1"){ | ||
$("#version-list").prepend("<li><a style='font-size:100%;' href="+"../latest/index.html"+"><span>Latest</span></a></li>"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asmeurer Need to update last line in releases.txt
on your server.
0.7.6.1:SymPy 0.7.6.1
---> latest:SymPy 0.7.6.1
.in my code currently i set 0.7.6.1
take as a latest version if you update this file then i change my condition 0.7.6.1
--> latest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That file is generated automatically from the release script. Would it be possible to just check what the last value in the file is, and set that to "latest"?
Yes. |
@asmeurer i added this condition and update my PR. |
It seems you've added jquery in multiple places. |
Is it possible to not duplicate popupmenu.css? |
We need to generate this automatically (update the generate_indexes.py script). When we release a new version, we should only have to run that script to fix everything. You can see what the release script runs here. |
In terms of the content, I would remove the "SymPy Versions" box. Instead just call the buttons "Latest version", "Development version", and "Other versions". Also, it seems to me that the versions in "other" should be sorted from latest to least latest (reverse of what it is now). Finally, can it highlight the version that we are presently on, and if we are on a non-latest version, have the "other" box be open by default, with the version we are on highlighted. |
@asmeurer Please check the changes. |
The pulsating "latest version" box is a bit confusing. It shows up when I mouse over an old version. Is that intentional? Can we highlight for the current page (I guess use the lighter green). |
|
That doesn't really indicate which version of the docs is currently active. |
|
@asmeurer I like to add "latest" background color is varies with time. Should i do ? |
IMO, background should be simple. I am -1 towards a "time varying" background color. |
@asmeurer As we discuss about Docker container. I built my own docker container and then i transfer this on Sympy docker container. give me detail about which dependency you want to run on Docker container. |
@asmeurer Please check the changes. |
Doesn't seem to work. "Latest" is always highlighted, even when pages for other versions. |
@asmeurer Sorry for delay, I added "latest" background color which is varies with time in Sympy 1.0 version. |
@asmeurer That's looks good? |
Thanks @mvnnn for working on this. |
The screenshots look pretty nice to me. @asmeurer any objections? |
@asmeurer that's looks good then i add this color change in all other version also. |
Yes:
And finally, whatever design we agree on should be incorporated into the generate_indices script, so that it works for future versions automatically (or alternately, added to our docs stylesheet in the sympy repo). |
Please check the changes. |
That looks good. |
issue sympy/sympy#6614