Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

really drop python<=3.7 support #896

Closed
wants to merge 3 commits into from
Closed

Conversation

kloczek
Copy link

@kloczek kloczek commented Oct 6, 2024

Description

Filter all code over pyupgracde --py38-plus.

Related Issues

N/A

Checklist

  • This PR has sufficient documentation.
  • This PR has sufficient test coverage.
  • This PR title satisfies semantic convention.

Additional Comments

No additional comments.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Filter all code over `pyupgracde --py38-plus`.

Signed-off-by: Tomasz Kłoczko <[email protected]>
Signed-off-by: Tomasz Kłoczko <[email protected]>
Looks like pytest passes correcrly with
`ruff check --fix --unsafe-fixes` as well.

Signed-off-by: Tomasz Kłoczko <[email protected]>
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #896   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files          21       21           
  Lines        1596     1597    +1     
=======================================
+ Hits         1563     1564    +1     
  Misses         33       33           

@noahnu
Copy link
Collaborator

noahnu commented Oct 17, 2024

None of the refactor this PR does actually removes any py3.7 specific constructs? What's the motivation for this PR?

That being said, it does seem to catch some redundant stylistic things so happy to get this merged as clean up.

@epenet epenet mentioned this pull request Nov 13, 2024
6 tasks
@noahnu
Copy link
Collaborator

noahnu commented Nov 18, 2024

Superseded by #921

@noahnu noahnu closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants