Add code comment about SQL queries in hc.front.views.ping_details

tank0226 · Jan 30, 2025 · b11f239 · b11f239
1 parent a965cee
commit b11f239
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/hc/front/views.py b/hc/front/views.py
@@ -742,6 +742,10 @@ def validate_schedule(request: HttpRequest) -> HttpResponse:
 def ping_details(
     request: AuthenticatedHttpRequest, code: UUID, n: int | None = None
 ) -> HttpResponse:
+    # This view makes two non-obvious SQL queries:
+    # * it calls ping.get_body(), which reads self.owner.code, triggering a query
+    # * the template calls ping.duration() which queries past "/start" events
+
     check, rw = _get_check_for_user(request, code)
     q = Ping.objects.filter(owner=check)
     if n: