Michael's review #44
Merged
Michael's review #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael's review 😉 |
spec.emu
Outdated
Comment on lines
1083
to
1085
| 1. <ins>For each Module Record _additionalModule_ of _additionalModules_, do</ins> | ||
| 1. <ins>If _additionalModule_ is not in _evaluationList_, then</ins> | ||
| 1. <ins>Append _additionalModule_ to _evaluationList_.</ins> |
There was a problem hiding this comment.
I don't think you need to go through all this to describe what you're really trying to do.
Suggested change
| 1. <ins>For each Module Record _additionalModule_ of _additionalModules_, do</ins> | |
| 1. <ins>If _additionalModule_ is not in _evaluationList_, then</ins> | |
| 1. <ins>Append _additionalModule_ to _evaluationList_.</ins> | |
| 1. <ins>Remove any duplicate entries from _additionalModules_.</ins> |
We talk about Lists having duplicate entries all over the place.
There was a problem hiding this comment.
Does this preserve ordering? I need to ensure that « x » + « y, x » becomes « x, y » and not « y, x »
There was a problem hiding this comment.
Ah, good point. No I don't think it would.
|
LGTM otherwise. |
|
Whops sorry about the typo 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #24 (comment)
@michaelficarra For
GatherAsynchronousTransitiveDependenciesI could not just use list concatenation because I need to avoid duplicates -- how does this look?