Add PR previews #33
Merged
Add PR previews #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syg
approved these changes
Sep 26, 2024
rbuckton
force-pushed
the
pr-preview
branch
from
4e9fadf to
17b3bd6
Compare
|
Is that "Error: Resource not accessible by integration" going to go away after this is merged? |
|
No, I think I need to change an Actions setting, but I don't have sufficient permissions on the repo. |
|
I'm still testing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this works, but can only test it by running it in GH actions. I'm adapting the PR build script I used here: https://github.com/tc39/proposal-class-static-block/blob/main/.github/workflows/pr.yml