-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easier debugging and troubleshooting of Test262 tests #1812
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1812 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 19 19
Lines 10960 10963 +3
Branches 1740 1740
=======================================
+ Hits 10408 10411 +3
Misses 537 537
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bc1f3c3
to
b503a6d
Compare
|
This commit enables running Test262 in debuggers like VSCode: * Adds a TIMEOUT environment variable (in msecs) to prevent the harnesss from killing the process while you're debugging it. Default is 10,000ms === 10 seconds. (same as existing default) * Works around a problem where passing tests were mistakenly labelled as failures when run in the debugger because of Node's debug-related console output. js-temporal/temporal-polyfill#46 requires this.
b503a6d
to
fc2e24c
Compare
Oh! I reverted that change and updated js-temporal/temporal-polyfill#46 to use the CLI parameter instead of an environment variable. Works great. One of these days I'll really have to learn more about UNIX shell scripting syntax. 😄 The other remaining changes in this PR are still needed to unblock js-temporal/temporal-polyfill#46. |
This PR enables running Test262 in debuggers like VSCode:
TIMEOUT
environment variable (in msecs) to prevent the harness from killing the process while you're debugging it. Default is 10,000ms === 10 seconds. (same as existing default)js-temporal/temporal-polyfill#46 depends on this PR to work properly.