Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for ECMA402 PR811 #3911

Merged
merged 10 commits into from
Sep 26, 2023
55 changes: 55 additions & 0 deletions test/intl402/NumberFormat/constructor-option-read-order.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
/// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-initializenumberformat
description: Checks the order of option read.
features: [Intl.NumberFormat-v3]
includes: [compareArray.js]
---*/

let optionKeys = [
// Inside InitializeNumberFormat
"localeMatcher",
"numberingSystem",
// Inside SetNumberFormatUnitOptions
"style",
"currency",
"currencyDisplay",
"currencySign",
"unit",
"unitDisplay",
// End of SetNumberFormatUnitOptions
// Back to InitializeNumberFormat
"notation",
// Inside SetNumberFormatDigitOptions
"minimumIntegerDigits",
"minimumFractionDigits",
"maximumFractionDigits",
"minimumSignificantDigits",
"maximumSignificantDigits",
"roundingIncrement",
"roundingMode",
"roundingPriority",
"trailingZeroDisplay",
// End of SetNumberFormatDigitOptions
// Back to InitializeNumberFormat
"compactDisplay",
"useGrouping",
"signDisplay"
];

// Use getters to track the order of reading known properties.
// TODO: Should we use a Proxy to detect *unexpected* property reads?
let reads = new Array();
let options = {};
optionKeys.forEach((key) => {
Object.defineProperty(options, key, {
get() {
reads.push(key);
return undefined;
},
});
});
new Intl.NumberFormat(undefined, options);
assert.compareArray(reads, optionKeys, "Intl.NumberFormat options read order");
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-intl.numberformat.prototype.resolvedoptions
description: order of property keys for the object returned by resolvedOptions()
features: [Intl.NumberFormat-v3]
includes: [compareArray.js]
---*/

const allKeys = [
'locale',
'numberingSystem',
'style',
'currency',
'currencyDisplay',
'currencySign',
'unit',
'unitDisplay',
'minimumIntegerDigits',
'minimumFractionDigits',
'maximumFractionDigits',
'minimumSignificantDigits',
'maximumSignificantDigits',
'useGrouping',
'notation',
'compactDisplay',
'signDisplay',
'roundingIncrement',
'roundingMode',
'roundingPriority',
'trailingZeroDisplay'
];

const optionsBase = { notation: 'compact' };
const optionsExtensions = [
{ style: 'currency', currency: 'XTS' },
{ style: 'unit', unit: 'percent' },
];
optionsExtensions.forEach((optionsExtension) => {
const options = Object.assign({}, optionsBase, optionsExtension);
const nf = new Intl.NumberFormat(undefined, options);
const resolved = nf.resolvedOptions();
const resolvedKeys = Reflect.ownKeys(resolved);
const expectedKeys = allKeys.filter(key => key in resolved);
assert.compareArray(resolvedKeys, expectedKeys,
'resolvedOptions() property key order with options ' + JSON.stringify(options));
});
53 changes: 53 additions & 0 deletions test/intl402/PluralRules/constructor-option-read-order.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
/// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-initializepluralrules
description: Checks the order of option read.
features: [Intl.NumberFormat-v3]
includes: [compareArray.js]
---*/

let optionKeys = [
// Inside InitializePluralRules
"localeMatcher",
"type",
// Inside SetNumberFormatDigitOptions
"minimumIntegerDigits",
"minimumFractionDigits",
"maximumFractionDigits",
"minimumSignificantDigits",
"maximumSignificantDigits",
"roundingPriority",
"roundingIncrement",
"roundingMode",
"trailingZeroDisplay",
FrankYFTang marked this conversation as resolved.
Show resolved Hide resolved
// End of SetNumberFormatDigitOptions
];
let expected = [
"localeMatcher",
"type",
"minimumIntegerDigits",
"minimumFractionDigits",
"maximumFractionDigits",
"minimumSignificantDigits",
"maximumSignificantDigits",
"roundingIncrement",
"roundingMode",
"roundingPriority",
"trailingZeroDisplay"
];
let readKeys = new Array();
// For each item returned by resolvedOptions of default, add a getter
// to track the reading order.
let opt = {};
optionKeys.forEach((property) =>
Object.defineProperty(opt, property, {
get() {
readKeys[readKeys.length] = property;
return undefined;
},
}));
let p = new Intl.PluralRules(undefined, opt);
assert.compareArray(readKeys, expected,
"GetOption should be called in the correct order");
FrankYFTang marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-intl.pluralrules.prototype.resolvedoptions
description: order of property keys for the object returned by resolvedOptions()
features: [Intl.NumberFormat-v3]
includes: [compareArray.js]
---*/

let expected = [
"locale",
"type",
"minimumIntegerDigits",
"minimumFractionDigits",
"maximumFractionDigits",
"pluralCategories",
"roundingIncrement",
"roundingMode",
"roundingPriority",
"trailingZeroDisplay"
];
FrankYFTang marked this conversation as resolved.
Show resolved Hide resolved
assert.compareArray(
Object.keys((new Intl.PluralRules()).resolvedOptions()),
expected,
"keys of resolvedOptions() should be in the correct order");