CI: Move from deprecated to supported Docker image #3948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The circleci/ images are deprecated and replaced by cimg/. Hopefully this will have a glibc that is new enough for XS's versioned symbols to link against. Rename 'node_latest' to 'node_image' since the image is the LTS, not the latest. The name would otherwise be confusing. Closes: tc39#3891
Ms2ger
approved these changes
Oct 19, 2023
ptomato
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The circleci/ images are deprecated and replaced by cimg/. Hopefully this will have a glibc that is new enough for XS's versioned symbols to link against.
Rename 'node_latest' to 'node_image' since the image is the LTS, not the latest. The name would otherwise be confusing.
Closes: #3891
[do not merge yet, I'm just opening a PR so that the CI jobs will run]Well what ya know, it worked!