RAB: fix reduce tests #4181
Merged
RAB: fix reduce tests #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oddly enough this could have been spotted via CI run failures, but they are reported as successful even though the output shows failures: https://app.circleci.com/pipelines/github/tc39/test262/6221/workflows/6638a1b0-4796-4d85-bfee-eca8d6331712/jobs/55623/parallel-runs/0/steps/0-106 |
* reduce callback has call signature «accumulator, kValue, 𝔽(k), O »
ptomato
force-pushed
the
fix-typed-array-reduce-acc
branch
from
fa61370 to
01ee1d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #4156 ,
Array.prototype.reducehad the correct signature for callback function, but typed array did not.reducecallback has call signature«accumulator, kValue, 𝔽(k), O»earlier the collected values contained the accumalator instead of the actual value.