add tests for "iterator helpers close receiver on argument validation failure" #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+20
to
+27
| return() { | ||
| closed = true; | ||
| }, | ||
| }; | ||
|
|
||
| assert.throws(RangeError, function() { | ||
| closable.take(); | ||
| }); |
There was a problem hiding this comment.
Since the return value of return is not an object, wouldn't TypeError be thrown before RangeError due to step 7 of IteratorClose?
There was a problem hiding this comment.
Both Iterator#map and Iterator#filter, etc pass the tests, but they probably do not behave as intended. In all tests, the return method of closable should return an object, I think.
There was a problem hiding this comment.
Implementing this normative change is likely to cause https://github.com/tc39/test262/blob/main/test/built-ins/Iterator/prototype/reduce/non-callable-reducer.js to start failing, because the underlying iterator will already be closed during the second call to reduce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for tc39/ecma262#3467, which has consensus and is just waiting for tests.
No existing tests were invalidated as far as I can tell (presumably because if we'd thought to test this behavior then we'd have updated the proposal instead of needing the PR).