DurationFormat: Add tests for durations with style: "digital"
, hoursDisplay: "auto"
and zero hours
#4367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
Intl.DurationFormat
in WebKit (JavaScriptCore) has passed all test262 test cases, but we discovered two incompatibilities with the specification. This Pull Request adds tests addressing those issues.The first one is described in bug 285078. A separator is printed erroneously for an unprinted hours value:
The second one is described in bug 285212. A negative sign is not printed:
Both issues occur when
style: "digital"
,hoursDisplay: "auto"
, and the hours value is 0 or absent. For that reason, they are combined into a single test file.