fix: chain should expand error types

tdreyno · Mar 5, 2020 · 1525053 · 1525053
1 parent 13d9c5a
commit 1525053
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/docs/task-instance.md b/docs/task-instance.md
@@ -140,7 +140,9 @@ const task: Task<unknown, number> = Task.of(5).chain(number =>
 {% tab title="Type Definition" %}
 
 ```typescript
-type chain = <S2>(fn: (result: S) => Task<E, S2> | Promise<S2>) => Task<E, S2>
+type chain = <S2>(
+  fn: (result: S) => Task<E2, S2> | Promise<S2>
+) => Task<E | E2, S2>
 ```
 
 {% endtab %}

diff --git a/src/Task/Task.ts b/src/Task/Task.ts
@@ -103,10 +103,10 @@ export const fork = <E, S>(
  * @param fn Takes a successful result and returns a new task.
  * @param task The task which will chain to the next one on success.
  */
-export const chain = <E, S, S2>(
-  fn: (result: S) => Task<E, S2> | Promise<S2>,
+export const chain = <E, S, E2, S2>(
+  fn: (result: S) => Task<E2, S2> | Promise<S2>,
   task: Task<E, S>
-): Task<E, S2> =>
+): Task<E | E2, S2> =>
   new Task((reject, resolve) =>
     task.fork(reject, b => autoPromiseToTask(fn(b)).fork(reject, resolve))
   )