[sembast] feat work on supporting read-only db

tekartik · Dec 3, 2024 · 55af734 · 55af734
1 parent e1755f9
commit 55af734
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/sembast/lib/src/database_impl.dart b/sembast/lib/src/database_impl.dart
@@ -464,6 +464,9 @@ class SembastDatabase extends Object
     // Not record, no commit
     if (txnRecords.isNotEmpty) {
       void saveInMemory() {
+        if (isReadOnly) {
+          throw DatabaseException.badParam('Read-only database');
+        }
         for (var record in txnRecords) {
           final exists = setRecordInMemory(record);
           // Try to estimated if compact will be needed
@@ -1367,9 +1370,6 @@ class SembastDatabase extends Object
 
             /// Replay the transaction if something has changed
             if (commitEntries.hasWriteData || commitEntries.upgrading) {
-              if (isReadOnly) {
-                throw DatabaseException.badParam('Read-only database');
-              }
               // Build Entries
               var entries = <JdbWriteEntry>[];
               for (var record in commitEntries.txnRecords!) {

diff --git a/sembast/test/database_format_test.dart b/sembast/test/database_format_test.dart
@@ -285,7 +285,7 @@ void defineTestsWithCodec(FileSystemTestContext ctx, {SembastCodec? codec}) {
         // Read-only database
         //print(_);
       }
-      expect(await record2.get(db), 'ho'); // ! read-only but not in memory
+      expect(await record2.get(db), isNull); // ! read-only but not in memory
       await db.close();
       db = await factory.openDatabase(dbPath, mode: DatabaseMode.readOnly);
       expect(await record2.get(db), isNull);

diff --git a/sembast_test/lib/open_test.dart b/sembast_test/lib/open_test.dart
@@ -208,12 +208,12 @@ void defineTests(DatabaseTestContext ctx) {
       expect(await record2.get(db), isNull);
       try {
         await record2.put(db, 'ho');
-        //fail('should fail');
+        fail('should fail');
       } on DatabaseException catch (_) {
         // Read-only database
         // print(_);
       }
-      // expect(await record2.get(db), 'ho'); // ! read-only but not in memory
+      expect(await record2.get(db), isNull); // ! read-only but not in memory
       await db.close();
       db = await factory.openDatabase(dbPath, mode: DatabaseMode.readOnly);
       // expect(await record2.get(db), isNull); to test