Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add legacy project templates #314

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Conversation

Tsvetomir-Hr
Copy link
Contributor

@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team December 16, 2024 15:57
@Tsvetomir-Hr Tsvetomir-Hr self-assigned this Dec 16, 2024
Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add a README.md file in the legacy with an explanation what these apps are.
  • Do we really need both server and WASM options for all apps? If there is no unique / different code for each hosting model, we can go with just one option. The goal is to show how to implement the Telerik-specific stuff, which usually does not depend on the hosting model.

@Tsvetomir-Hr
Copy link
Contributor Author

Tsvetomir-Hr commented Dec 18, 2024

  • Do we really need both server and WASM options for all apps? If there is no unique / different code for each hosting model, we can go with just one option. The goal is to show how to implement the Telerik-specific stuff, which usually does not depend on the hosting model.

How do we decide which hosting model to retain? If we keep only the Server hosting model, some clients will request the WASM example, and vice versa. I think the main intent behind transferring the source code from the vsx-templates to the blazor-ui repo is to retain the visibility and continued access.

@radkostanev
Copy link
Member

adding a README file explaining what these are is certainly a nice addition.

As for what hosting models to retain - I'd suggest simply moving these now as-is, and only if demand requires it, we may think of spending more time refactoring them.

@Tsvetomir-Hr Tsvetomir-Hr requested a review from dimodi December 30, 2024 11:38
@radkostanev radkostanev merged commit dad0564 into master Dec 31, 2024
@radkostanev radkostanev deleted the add-deprecated-templates branch December 31, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants