Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Remove the custom
MODULE_NOT_FOUND
error catchingWhy?
I was running into an issue earlier where I was getting this error:
ValueError: Could not find a file at the specified payloadConverterPath: '/workspace/typescript/src/payload-converter.ts'.
However, the error message was actually
Cannot find module './generated/root'
, which was a downstreamMODULE_NOT_FOUND
error. So, thepayload-converter.ts
file existed, but theroot
file it was importing didn't exist. However, the error message was misleading because it made me believe thatpayload-converter.ts
couldn't be found.I think it would be best to remove this custom catching logic and just throw an error if it does (in the else case anyways).