Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove custom error #1598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

albertlai431
Copy link

What was changed

Remove the custom MODULE_NOT_FOUND error catching

Why?

I was running into an issue earlier where I was getting this error: ValueError: Could not find a file at the specified payloadConverterPath: '/workspace/typescript/src/payload-converter.ts'.

However, the error message was actually Cannot find module './generated/root', which was a downstream MODULE_NOT_FOUND error. So, the payload-converter.ts file existed, but the root file it was importing didn't exist. However, the error message was misleading because it made me believe that payload-converter.ts couldn't be found.

I think it would be best to remove this custom catching logic and just throw an error if it does (in the else case anyways).

@albertlai431 albertlai431 requested a review from a team as a code owner January 14, 2025 01:49
@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants