Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use numbered list for env setup in Contribution Guide #1604

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

chadxz
Copy link
Contributor

@chadxz chadxz commented Jan 17, 2025

What was changed

  • Updated the environment setup portion of the contribution guide to use a numbered list instead of bullets.

Why?

When following this guide to setup my environment, I found myself skimming over the bulleted list instead of treating it as a set of tasks to complete. Using a numbered list for this section helps readability.

@chadxz chadxz requested a review from a team as a code owner January 17, 2025 18:28
@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
All committers have signed the CLA.

@mjameswh
Copy link
Contributor

Makes total sense. Thanks!

When following this guide to setup my environment, I found myself
skimming over the bulleted list instead of treating it as a set of tasks
to complete. Using a numbered list for this section helps readability.
@chadxz chadxz force-pushed the contributor-guide-environment-steps branch from 4e96e2b to db934b4 Compare January 17, 2025 19:33
@chadxz
Copy link
Contributor Author

chadxz commented Jan 17, 2025

@mjameswh Thanks! I saw that it had a lint error so I pushed a fix for that. Hopefully g2g now.

@mjameswh mjameswh merged commit b434d9f into temporalio:main Jan 21, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants