Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Replace broken otel doc link with sample link #1609

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

chadxz
Copy link
Contributor

@chadxz chadxz commented Jan 21, 2025

What was changed

On the OpenTelemetry interceptor README, I replaced a link to an anchor that no longer exists on the Temporal TypeScript SDK documentation page with a new link to an implementation sample of the OpenTelemetry interceptor in the samples-typescript repository.

Why?

To help people like myself looking for how to implement the interceptor.

@chadxz chadxz requested a review from a team as a code owner January 21, 2025 21:44
Copy link
Contributor

@mjameswh mjameswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's helpful!

@mjameswh mjameswh merged commit d8925d0 into temporalio:main Jan 21, 2025
22 checks passed
@chadxz chadxz deleted the remove-broken-otel-docs-link branch January 22, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants