-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new flexible loss named GeneralLoss #1647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ashutosh1919 , thanks for the PR. Because this PR is somewhat large, let's improve it step by step :-)
For testing, please follow other tests in loss module.
https://github.com/tensorflow/addons/blob/master/tensorflow_addons/losses/tests/kappa_loss_test.py
As a side note, maybe we should reconsider the name "GeneralLoss"? It may be confusing for users. They may think it's some kind of abstract base class. We also changed the CI quite a bit recently, so I'm merging master to make sure everything works. Please do git pull before adding new commits. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@gabrieldemarmiesse , Yes you are right. We should think about better name here. |
@gabrieldemarmiesse , @WindQAQ - How about the name |
Not a good one IMO |
Cache invalidation is easier IMO |
Some suggestions for name:
|
@gabrieldemarmiesse , Any update on this PR? Thanks! |
|
@gabrieldemarmiesse , @bhack , @AakashKumarNain - Any suggestion for name to go ahead with this PR? |
It don't know what to do exactly with all these Docs repos. |
Yes I was fooled by github notifications |
Thank you for your contribution. We sincerely apologize for any delay in reviewing, but TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision: Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA: |
fixes #1646.
@gabrieldemarmiesse , @pavithrasv and @mihaimaruseac, please review.