Fix dataset downloads from Google Drive #10963
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago, when downloading big files from Google Drive, Google introduced a confirmation page that warns about the file not being virus-checked. Since the direct download links in TFDS were no longer functional, we tried to circumvent this confirmation page by appending
confirm=tto the URL.More recently, Google also disallows this circumvention by adding a temporary UUID to the confirmation download URLs, so it is no longer possible to download from GDrive using a static URL.
Several datasets therefore are no longer functional, throwing a
NonMatchingChecksumError:This PR parses the retrieved confirmation page and extracts the confirmation download URL, fixing downloading of the above datasets.
Fixes #8981, #5729, #5232, #5544, #5535.