Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field name checks for StructTuple #1828

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Field name checks for StructTuple #1828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tensorflow_probability/python/internal/structural_tuple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ def _validate_field_names(field_names):
if name.startswith('_'):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this will prevent name="__gt__"

raise ValueError(
'Field names cannot start with an underscore: {}'.format(name))
if name in dir(tuple):
raise ValueError(
'Field name {} is already a member of StructTuple'.format(name))
if name in seen:
raise ValueError('Encountered duplicate field name: {}'.format(name))
seen.add(name)
Expand Down
Loading