This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
tf.image.transform no-shader implementation #1641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piercus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix tensorflow/tfjs#1426 and replaces #1637
After trying to implement specific webgl/cpu shaders in #1637 i realized
ImageProjectiveTransformis not available in the ops list of C API.Considering this, I've implemented it in a no-shader way, using
tf.gatherNDas the cornerstone of the implementation.This new version won't need to maintain multiple shaders but may be a little bit slower (i haven't fully tested the performance yet)
Since the implementation takes 300 lines, i have put it into a separated file required in
image_ops.ts.Please share your feedbacks and suggestions :-)
This change is