[ts-scripts] remove saveImages() test. (#3815)

The `saveImages()` function can't be tested without mocking because it
uses `docker pull` and `docker save`, which we don't want to do in CI.
That would defeat the purpose of creating a cache of docker images. This
is only used for CI caching purposes, so loss of test coverage is
acceptable.

Ref: #3728

packages/scripts/test/images-spec.ts

@@ -1,19 +1,17 @@
 import 'jest-extended';
-import { jest } from '@jest/globals';
 import fs from 'node:fs';
-import { createImageList, saveImages } from '../src/helpers/images/index.js';
-import * as scripts from '../src/helpers/scripts.js';
+import { createImageList } from '../src/helpers/images/index.js';
 import * as config from '../src/helpers/config.js';
 
-describe('images', () => {
+describe('images command', () => {
     afterEach(() => {
         if (fs.existsSync(config.DOCKER_IMAGES_PATH)) {
             fs.rmSync(config.DOCKER_IMAGES_PATH, { recursive: true, force: true });
         }
     });
 
-    describe('list', () => {
-        it('should create a txt file containing a list of images for teraslice testing', async () => {
+    describe('list docker images', () => {
+        it('should create a txt file containing a list of docker images for teraslice testing', async () => {
             await createImageList();
             expect(fs.existsSync(config.DOCKER_IMAGE_LIST_PATH)).toBe(true);
             const fileContents = fs.readFileSync(config.DOCKER_IMAGE_LIST_PATH, 'utf-8');
@@ -27,28 +25,4 @@ describe('images', () => {
             expect(fileContents).toContain(config.KIND_DOCKER_IMAGE);
         });
     });
-
-    /*
-        @TODO modules are readonly in esm, its bad to mock this way,
-        should either mock the http response or refactor the code
-        to make it easier to mock
-    */
-    describe.skip('save', () => {
-        beforeAll(() => {
-            const dockerPullMock = jest.spyOn(scripts, 'dockerPull');
-            const saveAndZipMock = jest.spyOn(scripts, 'saveAndZip');
-
-            dockerPullMock.mockImplementation(async () => {});
-            saveAndZipMock.mockImplementation(async () => {});
-        });
-
-        it('should call dockerPull and saveAndZip for all images from DOCKER_IMAGE_LIST_PATH', async () => {
-            await createImageList();
-            await saveImages();
-
-            expect(fs.existsSync(config.DOCKER_CACHE_PATH)).toBe(true);
-            expect(scripts.dockerPull).toHaveBeenCalledTimes(11);
-            expect(scripts.saveAndZip).toHaveBeenCalledTimes(11);
-        });
-    });
 });