Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to k8s js client from kubectl in k8senv #3476

Merged
merged 11 commits into from
Nov 30, 2023
Merged

Convert to k8s js client from kubectl in k8senv #3476

merged 11 commits into from
Nov 30, 2023

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Nov 27, 2023 •
edited
Loading

This Pr includes the following changes:

  • adds the @kubernetes/client-node package to ts-scripts
  • replace the use of kubectl with the k8s node client when starting teraslice with the k8s-env command

Future improvements:

  • replace kubectl command when starting services
  • use the k8s node client in k8s e2e tests

@busma13 busma13 requested a review from godber November 27, 2023 20:29
@godber godber changed the title Add k8s client to k8s env Convert to k8s js client from kubectl in k8senv Nov 27, 2023
@busma13 busma13 marked this pull request as ready for review November 28, 2023 14:47
@godber godber merged commit 7d9c893 into master Nov 30, 2023
39 checks passed
@godber godber deleted the add-k8s-client-to-k8s-env branch November 30, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@busma13 @godber