Add the --rebuild option to the k8s-env command #3480
Conversation
Yeah, there will be cases for both. |
e2e/test/teraslice-harness.js
Outdated
| @@ -22,12 +22,15 @@ const { cleanupIndex } = ElasticsearchTestHelpers; | |||
|
|
|||
| const generateOnly = GENERATE_ONLY ? parseInt(GENERATE_ONLY, 10) : null; | |||
|
|
|||
| const TERASLICE_PORT = 45678; | |||
There was a problem hiding this comment.
I'm not sure if this is accessible in this scope, but here's another place this port is defined:
In the scripts package, so maybe it does't make sense to have this dependency, or maybe it should go the other way.
There was a problem hiding this comment.
- The teraslice port was a magic number in
e2e/test/teraslice-harness.jsande2e/test/global.setup.js, so I just made it a constant so things were more explicit. I should be able to pass the value from one to the other. - In my first attempt to declare the teraslice port, I placed it in
helpers/scripts.ts, then modified it if we were in k8s-env mode, not testing mode. I then removed the declaration in favor of passing the port in from either theglobal.setup.jsconstant or thek8s-envcommand options. - Ports are also hard coded into some yaml files. It would be nice to set a variable once and pass it everywhere needed!
e2e/test/global.setup.js
Outdated
| @@ -16,6 +16,8 @@ const { | |||
| CONFIG_PATH, ASSETS_PATH, TEST_PLATFORM | |||
| } = require('./config'); | |||
|
|
|||
| const TERASLICE_PORT = 45678; | |||
There was a problem hiding this comment.
You have this variable set elsewhere too.
There was a problem hiding this comment.
Is is a problem if it gets updated in one place but not the other? If so, you have a problem.
| } | ||
|
|
||
| async deleteTerasliceNamespace() { | ||
| async confirmDeletion(terasliceNamespace: string, coreV1Api: k8sClient.CoreV1Api) { |
There was a problem hiding this comment.
This is a pretty vague function name, if it means confirmNamespaceDeletetion you might name it that.
| @@ -21,7 +21,6 @@ import { getE2eK8sDir } from '../helpers/packages'; | |||
| import { yamlDeploymentResource, yamlServiceResource } from './k8s-env/interfaces'; | |||
|
|
|||
| const logger = debugLogger('ts-scripts:cmd'); | |||
| let TS_PORT = '45678'; | |||
There was a problem hiding this comment.
Now I'm confused about this TS_PORT thing.
This PR includes the following changes:
--rebuildoption tots-scripts k8s-envyarn k8s:rebuildscript from root of terasliceyarn k8s. Now services and the cluster do not need to be rebuilt.