Add K8s version parameter to kind cluster creation #3500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godber
approved these changes
Dec 14, 2023
packages/scripts/src/helpers/kind.ts
Outdated
| } | ||
| } | ||
|
|
||
| const map = { |
There was a problem hiding this comment.
I would avoid every using a name as generic as map. You don't need to change this now, but next time your come across this I'd give it a more descriptive name.
|
I want to merge this, please bump the version and let me know after you do and I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K8S_VERSIONenv variable when runningyarn test:k8soryarn k8s(K8s - parameterize k8s version in kind (e2e tests and k8s-env command) #3482)Kindclass to create a kind cluster using that k8s version.kindversions to available images lives in theKindclass and will need to be updated with new kind versions.clusterNameoption to k8s