Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caCertificate option for s3 connector #3584

Merged
merged 27 commits into from
Apr 11, 2024
Merged

Add caCertificate option for s3 connector #3584

merged 27 commits into from
Apr 11, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Apr 2, 2024 •
edited by busma13
Loading

This PR makes the following changes:

  • Adds caCertificate option inside of the s3 connector configuration which allows the user to pass in a ca-certificate inside of config instead of reading it from a file.
  • Deprecates certLocation inside of the s3 connector configuration
  • Updates file-asset-apis from v0.12.2 to v0.13.0
  • Adds cross-validation functionality that now checks s3 connector configuration for conflicting settings
  • Bumps terafoundation from v0.59.1 to v0.60.0

Ref to issue #1070

@sotojn sotojn self-assigned this Apr 2, 2024
@sotojn sotojn requested a review from busma13 April 4, 2024 17:20
busma13
busma13 requested changes Apr 4, 2024
View reviewed changes
packages/terafoundation/src/connectors/s3.ts Outdated Show resolved Hide resolved
packages/terafoundation/src/connectors/s3.ts Outdated Show resolved Hide resolved
busma13
busma13 requested changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm just nitpicking documentation

packages/terafoundation/src/connectors/s3.ts Outdated Show resolved Hide resolved
packages/terafoundation/src/connectors/s3.ts Outdated Show resolved Hide resolved
sotojn and others added 16 commits April 5, 2024 16:12
@sotojn
add caCertificate to s3 connector schema
b5b4d3c
@sotojn
remove maxRedirects from s3 connector schema
4529da0
@sotojn
add connector specific validation functionality
691b6ad
@sotojn
add s3 connection validation
b9441e2
@sotojn
check if mod exists in getConnectorValidation
3394393
@sotojn
fix lint errors
0024edc
@sotojn
change sslenabled default to false
ff8c45b
@sotojn
set sslenabled default back to true
5f9b911
@sotojn
add global_ca_certificate option in terafoundation schema
8419e2b
@sotojn
update cert docs in s3 connector
8e76aaa
@sotojn
update terafoundation docs
6660744
@sotojn @busma13
update caCertificate doc
21ec6b4 
Co-authored-by: Peter Luitjens <[email protected]>
@sotojn @busma13
fix spelling error in certLocation docs in s3 connector
485c603 
Co-authored-by: Peter Luitjens <[email protected]>
@sotojn
refactor validator in s3 connector
3145f18
@sotojn
bump: (minor) [email protected]
02eb77c
@sotojn
release: (minor) [email protected]
a4727ef
@sotojn sotojn force-pushed the s3-caCertificate-option branch from 90a6402 to a4727ef Compare April 5, 2024 23:13
@sotojn sotojn marked this pull request as ready for review April 5, 2024 23:16
@sotojn sotojn requested a review from godber April 5, 2024 23:21
@busma13 busma13 mentioned this pull request Apr 9, 2024
Open
@busma13 busma13 self-assigned this Apr 11, 2024
@jsnoble jsnoble merged commit 748fbe5 into master Apr 11, 2024
40 checks passed
@jsnoble jsnoble deleted the s3-caCertificate-option branch April 11, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busma13 busma13 busma13 approved these changes

@godber godber Awaiting requested review from godber

Assignees

@busma13 busma13

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sotojn @busma13 @jsnoble