Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled deps update #3593

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Bundled deps update #3593

merged 3 commits into from
Apr 12, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Apr 12, 2024

This PR makes the following changes:

  • Updates s3_store-spec tests to import from file-asset-apis instead of aws-sdk
  • Remove aws-sdk as a dependency in terafoundation
  • Updates the following dependencies:
    • express from v4.18.2 to v4.19.2
    • gc-stats from v1.4.0 to v1.4.1
    • nanoid from v3.3.6 to v3.3.7
    • tmp from v0.2.1 to v0.2.3
    • yeoman-generator from v5.9.0 to v5.10.0
    • @types/semver from v7.5.6 to v7.5.8
    • nock from v13.5.1 to v13.5.4

@sotojn sotojn self-assigned this Apr 12, 2024
@sotojn sotojn requested review from godber and busma13 April 12, 2024 17:47
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@@ -1,8 +1,7 @@
import fse from 'fs-extra';
import { Logger } from '@terascope/utils';
import { TestContext, TestContextOptions } from '@terascope/job-components';
import { DeleteBucketCommand } from '@aws-sdk/client-s3';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests were written before I knew to use deleteS3Bucket from file-asset-apis. This should have been changed in the original PR.

@godber godber merged commit 92501f9 into master Apr 12, 2024
40 checks passed
@godber godber deleted the bundled-deps-update-April-12-2024 branch April 12, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants