Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper label functionality to mockPromMetrics #3603

Merged
merged 3 commits into from
May 2, 2024
Merged

Add proper label functionality to mockPromMetrics #3603

merged 3 commits into from
May 2, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented May 2, 2024 •
edited
Loading

This PR makes the following changes:

  • Adds the ability for mockPromMetrics in the job-components TestContext to properly gather metrics by labels. This was necessary to test count_by_field in standard-assets.
  • Add clusterManagerType to JobHarnessOptions used by the base-test-harness. This will set context.sysconfig.teraslice.cluster_manager_type, which must be kubernetes for prom metrics to be enabled.

@busma13 busma13 requested a review from godber May 2, 2024 18:38
@busma13 busma13 marked this pull request as ready for review May 2, 2024 18:38
@busma13 busma13 mentioned this pull request May 2, 2024
Merged
@godber godber merged commit 879af42 into master May 2, 2024
40 checks passed
@godber godber deleted the mock-prom-metrics-label-properly branch May 2, 2024 20:54
@godber godber temporarily deployed to github-pages May 2, 2024 21:03 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@busma13 @godber