e2e TLS minio test coverage #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sotojn
force-pushed
the
e2e-cert-test-coverage
branch
from
14c93c2 to
87e8304
Compare
godber
reviewed
Jun 28, 2024
| done | ||
| echo "$DNS_NAMES" | ||
| if [ -d "$CERT_DIR" ]; then | ||
| rm -rf $CERT_DIR |
There was a problem hiding this comment.
I think this is safe enough the way it is currently implemented, but make sure you think long and hard anytime you add an rm -rf $var to your scripts. Make sure there's no way to screw up $var. One thing you can do (it doesn't matter in this case) is set -u, to treat unset variables as errors. I'm not asking for a change here, just warning you.
godber
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
minioservicesgenerate-certs.shscript that quickly builds new certs forminiousing mkcertv.0.78.0