-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'images list' cmd to use config variables, not hardcoded values #3690
Conversation
e3e840a
to
4acb1b4
Compare
a99cc78
to
eea51a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to approve this PR but I REALLY dislike the use of environment variables and would like to push for us to STOP using them except were absolutely necessary (like passing stuff to jest). The reason I dislike it is that they can be abused and used as global variables. This PR does not abuse that and all of the uses are confined to config.ts and then properties on config. This is OK. But if people start using process.env
to access these values all over the place we will start shooting ourselves in the foot.
This PR makes the following changes:
config.ts
:images list
command creates the image tags and versions based off the values inconfig.ts
instead of hard-coded values.config.ts