Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary support to is base64 #3691

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Conversation

jeffmontagna
Copy link
Contributor

Issue

isBase64 in data-mate has the following issues:

  • Assumes all encoded data is a string, i.e. binary data encoded is converted to a string which then fails the check.
  • Does not check for base64 url

Changes

  • Remove conversion to string when decoding value to check.
  • Added base64Url and base64Url with padding checks. isBase64 returns true for base64, base64Url and base64Url with padding.

e2e/README.md Outdated Show resolved Hide resolved
packages/data-mate/README.md Outdated Show resolved Hide resolved
packages/data-types/README.md Outdated Show resolved Hide resolved
packages/docker-compose-js/README.md Outdated Show resolved Hide resolved
packages/elasticsearch-api/README.md Outdated Show resolved Hide resolved
packages/types/README.md Outdated Show resolved Hide resolved
packages/utils/README.md Outdated Show resolved Hide resolved
packages/xlucene-parser/README.md Outdated Show resolved Hide resolved
packages/xlucene-translator/README.md Outdated Show resolved Hide resolved
packages/xpressions/README.md Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
remove e2e that snuck in
@godber godber merged commit d2d12e7 into master Jul 23, 2024
62 checks passed
@godber godber deleted the add-binary-support-to-isBase64 branch July 23, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants