Fix node version check in k8s --dev mode #3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busma13
reviewed
Jul 24, 2024
sotojn
force-pushed
the
k8s-dev-option-bug-fix
branch
from
3cb46c8 to
4a4e0b5
Compare
busma13
reviewed
Jul 25, 2024
sotojn
force-pushed
the
k8s-dev-option-bug-fix
branch
from
4a4e0b5 to
1783823
Compare
godber
approved these changes
Jul 26, 2024
godber
pushed a commit
that referenced
this pull request
Jul 26, 2024
This PR makes the following changes: - allows empty lists to be created in `scripts images list` - prevents `scripts images save` from failing on an empty string. This allows any repo that doesn't require images to use workflows using these commands without failing Waiting on #3701 so I can bump scripts again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
ts-scripts k8s --devthat will fail when env variableNODE_VERSIONis a major versionv0.83.0tov0.83.1