Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readiness probe to k8s job in KubernetesV2 backend #3721

Merged
merged 16 commits into from
Aug 22, 2024
Merged

Add readiness probe to k8s job in KubernetesV2 backend #3721

merged 16 commits into from
Aug 22, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Aug 16, 2024 •
edited
Loading

This PR makes the following changes:

  • Adds readiness probe to execution controller job (Only applies to k8s V2 backend)
    • Worker deployments will now wait for the ex readiness probe to come back as ready before creation.
  • Adds /ready endpoint to execution controller server
    • Will return with status code 200 when initializing is complete
    • Will return with status code 503 when initializing either fails or hasn't yet completed
  • Bumps @terascope/teraslice-messaging from v1.2.0 to v1.3.0

Ref to issue #3720

@sotojn sotojn self-assigned this Aug 16, 2024
@sotojn sotojn force-pushed the add-readiness-probe-k8s-job branch from a8163f8 to 68ae965 Compare August 20, 2024 20:47
@sotojn sotojn marked this pull request as ready for review August 21, 2024 18:19
@sotojn sotojn requested review from busma13 and godber August 21, 2024 18:42
busma13
busma13 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

godber
godber requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@godber godber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change the original kubernetes backend.

packages/teraslice-messaging/src/execution-controller/server.ts Show resolved Hide resolved
packages/teraslice/src/lib/cluster/services/cluster/backends/kubernetes/index.ts Outdated Show resolved Hide resolved
@sotojn @godber
Reduce readiness probe delays
86827b9 
Co-authored-by: Austin Godber <[email protected]>
@godber godber changed the title Add readiness probe to k8s job Add readiness probe to k8s job in KubernetesV2 backend Aug 22, 2024
@godber godber merged commit b9e3fa8 into master Aug 22, 2024
67 checks passed
@godber godber deleted the add-readiness-probe-k8s-job branch August 22, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busma13 busma13 busma13 approved these changes

@godber godber godber approved these changes

Assignees

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sotojn @godber @busma13