Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Prevent the dockerUp function from failing by retrying when node version check returns undefined #3741

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Sep 6, 2024

This PR makes the following changes:

  • Wrap node version check in a pRetry and throw if undefined. Occasionally e2e tests will fail because using docker compose to exec into the teraslice master and checking the node version will return undefined. It is most likely a timing issue, so we will now attempt this 3 times and then throw if we still get undefined.
  • Bump scripts from 0.7.0 to 0.7.1

@busma13 busma13 marked this pull request as ready for review September 6, 2024 16:41
@busma13 busma13 requested review from sotojn and godber September 6, 2024 16:41
@sotojn
Copy link
Contributor

sotojn commented Sep 6, 2024

Are you saying this happens because runCmd() executes the command and the command fails, leaving undefined as the result?

Copy link
Contributor

@sotojn sotojn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a good fix in the event docker fails to execute at that moment.

@busma13
Copy link
Contributor Author

busma13 commented Sep 6, 2024

Are you saying this happens because runCmd() executes the command and the command fails, leaving undefined as the result?

I have not been able to reproduce locally. All I know is that compose.runCmd does not error and receives undefined as stdout to docker compose exec teraslice-master node --version. My guess is that node --version fails for some unknown reason.

@godber godber merged commit 64f6ec5 into master Sep 10, 2024
66 checks passed
@godber godber deleted the node-version-check-retry branch September 10, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants