[scripts, teraslice-cli, ts-transforms] Update execa from 5.1.0 to 9.4.0 #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busma13
commented
Sep 26, 2024
Comment on lines
+72
to
+74
| if (typeof stdout !== 'string') { | ||
| throw new Error('exec() requires ExecOpts that result in a stdout string. See the execa docs for details.'); | ||
| } |
There was a problem hiding this comment.
Depending on the ExecOpts passed into exec stdout could be any of 'string | string[] | Uint8Array | unknown[]'. We don't use any options that change the stdout return type and always expect a string, so I think this should be fine. Though the error message could be better
busma13
force-pushed
the
update-execa
branch
from
bfc33eb to
d834959
Compare
godber
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes: