Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[teraslice-cli] Convert teraslice-cli to compile with esbuild #3851

Merged
merged 8 commits into from
Dec 6, 2024
Merged

[teraslice-cli] Convert teraslice-cli to compile with esbuild #3851

merged 8 commits into from
Dec 6, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Dec 4, 2024 •
edited
Loading

This PR makes the following changes:

  • Compile teraslice-cli with esbuild and push to npm
    • This resolves issues with nested dependencies potentially breaking teraslice-cli and allows for a consistent deliverable to npm
  • Bumps teraslice-cli from v2.8.2 to v2.9.0
  • Adds additional testing for the bundled javascript file
  • FIxes version unknown bug that occurs when running -v or --version flag

#3850

@sotojn sotojn self-assigned this Dec 4, 2024
@sotojn
Copy link
Contributor Author

sotojn commented Dec 4, 2024

Testing with a local registry, the size of teraslice-cli gets reduced from 147.2mb to 22.8mb approximately. Also it goes from installing 373 packages to only installing 3 packages.

@sotojn sotojn marked this pull request as ready for review December 5, 2024 23:32
@sotojn sotojn requested review from busma13 and godber December 5, 2024 23:33
busma13
busma13 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can you add something about the version fix to the PR description?

@godber godber merged commit a9b09c9 into master Dec 6, 2024
48 checks passed
@godber godber deleted the teraslice-cli-esbuild branch December 6, 2024 16:22
@sotojn sotojn mentioned this pull request Dec 13, 2024
Merged
busma13 pushed a commit that referenced this pull request Dec 17, 2024
@sotojn
[teraslice-cli] Fix build:watch command (#3877)
cda74ec 
This PR makes the following changes:

- Fixes an issue introduced in #3851 that breaks `build:watch` 
- This now properly compiles/bundles `teraslice-cli` on watch mode when
a change is made
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busma13 busma13 busma13 approved these changes

@godber godber godber approved these changes

Assignees

@sotojn sotojn

Labels
enhancement pkg/teraslice-cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sotojn @godber @busma13