Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[teraslice, scripts] Ci test error logging and potential fixes #3854

Merged
merged 21 commits into from
Dec 16, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Dec 5, 2024

This PR makes the following changes:

  • Adds the --verbose flag to the root package.json build script and removes --silent from YARN_SETUP_ARGS. This will hopefully reveal why the script fails occasionally. ref: yarn build failure in CI #3849
  • Replace unmaintained porty library with get-port library.
  • Within the teraslice package, many tests use findPort() to get a random port to start a server on. The implementation did not actually return a random port and made conflicts more likely. Update findPort() to use get-port, increase the port range, and get a truly random port in that range. ref: port in use errors in CI #3848
  • When starting services, log all TCP ports just before calling docker run. This should give us more information about why the docker run commands occasionally fail with a port already in use error. ref: port in use errors in CI #3848

@busma13 busma13 changed the title Ci test errors [teraslice, scripts] Ci test error logging and potential fixes Dec 5, 2024
@busma13 busma13 marked this pull request as ready for review December 5, 2024 22:11
@busma13 busma13 requested review from godber and sotojn December 5, 2024 22:11
@godber godber requested a review from jsnoble December 6, 2024 18:29
@busma13 busma13 marked this pull request as draft December 6, 2024 21:05
@busma13 busma13 marked this pull request as ready for review December 10, 2024 15:25
@busma13 busma13 requested a review from godber December 10, 2024 17:41
Copy link
Member

@godber godber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see me comments and lets discuss

packages/scripts/src/helpers/scripts.ts Outdated Show resolved Hide resolved
@busma13 busma13 force-pushed the ci-test-errors branch 3 times, most recently from fe14cf4 to ceb179a Compare December 13, 2024 16:09
bump: (minor) @terascope/[email protected], @terascope/[email protected]

bump: (minor) @terascope/[email protected], @terascope/[email protected]

bump: (minor) [email protected], [email protected]

bump: (minor) [email protected], [email protected]

bump: (minor) [email protected], @terascope/[email protected]

bump: (minor) @terascope/[email protected], @terascope/[email protected]
@godber godber merged commit d75756c into master Dec 16, 2024
46 checks passed
@godber godber deleted the ci-test-errors branch December 16, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants