-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[teraslice, scripts] Ci test error logging and potential fixes #3854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busma13
changed the title
Ci test errors
[teraslice, scripts] Ci test error logging and potential fixes
Dec 5, 2024
busma13
force-pushed
the
ci-test-errors
branch
from
December 6, 2024 16:38
f68d2b4
to
ddb8b98
Compare
godber
approved these changes
Dec 6, 2024
godber
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see me comments and lets discuss
busma13
force-pushed
the
ci-test-errors
branch
3 times, most recently
from
December 13, 2024 16:09
fe14cf4
to
ceb179a
Compare
busma13
force-pushed
the
ci-test-errors
branch
from
December 16, 2024 18:23
e052fe6
to
0a1e3ed
Compare
godber
approved these changes
Dec 16, 2024
bump: (minor) @terascope/[email protected], @terascope/[email protected] bump: (minor) @terascope/[email protected], @terascope/[email protected] bump: (minor) [email protected], [email protected] bump: (minor) [email protected], [email protected] bump: (minor) [email protected], @terascope/[email protected] bump: (minor) @terascope/[email protected], @terascope/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
--verbose
flag to the root package.jsonbuild
script and removes--silent
fromYARN_SETUP_ARGS
. This will hopefully reveal why the script fails occasionally. ref: yarn build failure in CI #3849porty
library withget-port
library.findPort()
to get a random port to start a server on. The implementation did not actually return a random port and made conflicts more likely. UpdatefindPort()
to useget-port
, increase the port range, and get a truly random port in that range. ref: port in use errors in CI #3848docker run
. This should give us more information about why thedocker run
commands occasionally fail with aport already in use
error. ref: port in use errors in CI #3848