Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npm auth token for yarn 4 #3897

Merged
merged 5 commits into from
Jan 10, 2025
Merged

fix npm auth token for yarn 4 #3897

merged 5 commits into from
Jan 10, 2025

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Jan 10, 2025

This PR makes the following changes:

  • Fixes issue where yarn wasn't getting an npm auth token when publishing packages.

@sotojn sotojn self-assigned this Jan 10, 2025
@sotojn sotojn requested review from godber and busma13 January 10, 2025 15:40
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busma13
Copy link
Contributor

busma13 commented Jan 10, 2025

Are these lines still needed in both the publish workflows?

- name: Verify npm authentication
   run: npm whoami

@godber godber merged commit e064a54 into master Jan 10, 2025
46 checks passed
@godber godber deleted the fix-npm-publish branch January 10, 2025 16:29
busma13 pushed a commit that referenced this pull request Jan 10, 2025
This PR makes the following changes:

- Fixes issue where yarn wasn't getting an npm auth token when
publishing packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants