feat: add support for hugepages_config #2223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrFaust92
changed the title
|
/gcbrun |
apeabody
requested changes
Dec 24, 2024
There was a problem hiding this comment.
Thanks for the contribution @DrFaust92!
Can you please add to an example for test coverage, otherwise other than some extra spaces, this LGTM.
NOTE: hugepages_config added in v6.5.0
|
@apeabody Tried my best with tests here as well 😊 . LMK if something needs fixing |
|
/gcbrun |
|
FYI @DrFaust92 - A few of the pools do use |
|
@apeabody should i change the node pools types to support the test case? or how should I approach this? |
The 2-m huge pages should be fine as-is, however for the 1-g perhaps just test a single node pool which has a supported machine type. Maybe change
|
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
|
apeabody lets try now |
|
/gcbrun |
apeabody
reviewed
Jan 6, 2025
| )) != 0 ? [1] : [] | ||
|
|
||
| content { | ||
| hugepage_size_2m = coalesce(local.node_pools_hugepage_size_2m[each.value["name"]], local.node_pools_hugepage_size_2m["all"], null) |
There was a problem hiding this comment.
My confusion, these coalesce() need a try() to properly return the default null:
Suggested change
| hugepage_size_2m = coalesce(local.node_pools_hugepage_size_2m[each.value["name"]], local.node_pools_hugepage_size_2m["all"], null) | |
| hugepage_size_2m = try(coalesce(local.node_pools_hugepage_size_2m[each.value["name"]], local.node_pools_hugepage_size_2m["all"]), null) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.