Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support simple sa creation without any project level roles #149

Merged
merged 1 commit into from
Jan 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2024 Google LLC
# Copyright 2025 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion modules/key-distributor/metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2024 Google LLC
# Copyright 2025 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion modules/simple-sa/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module "sa" {
| display\_name | Display name of the created service accounts (defaults to 'Terraform-managed service account') | `string` | `"Terraform-managed service account"` | no |
| name | Name of service account | `string` | n/a | yes |
| project\_id | Project id where service account will be created | `string` | n/a | yes |
| project\_roles | Roles to grant the SA in specified project | `list(string)` | n/a | yes |
| project\_roles | Roles to grant the SA in specified project | `list(string)` | `[]` | no |

## Outputs

Expand Down
4 changes: 2 additions & 2 deletions modules/simple-sa/metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2024 Google LLC
# Copyright 2025 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -61,7 +61,7 @@ spec:
- name: project_roles
description: Roles to grant the SA in specified project
varType: list(string)
required: true
defaultValue: []
connections:
- source:
source: github.com/GoogleCloudPlatform/terraform-google-secret-manager//modules/simple-secret
Expand Down
1 change: 1 addition & 0 deletions modules/simple-sa/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,5 @@ variable "description" {
variable "project_roles" {
type = list(string)
description = "Roles to grant the SA in specified project"
default = []
}
Loading