Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for maintenance version #679

Merged
merged 7 commits into from
Jan 24, 2025
Merged

feat: added support for maintenance version #679

merged 7 commits into from
Jan 24, 2025

Conversation

imrannayer
Copy link
Collaborator

fixed #610
fixed #662

@imrannayer imrannayer requested review from isaurabhuttam, q2w and a team as code owners December 17, 2024 19:45
@imrannayer imrannayer self-assigned this Jan 8, 2025
@imrannayer
Copy link
Collaborator Author

@q2w plz review

g-awmalik
g-awmalik approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you check if this requires a version bump for the modules?

@imrannayer
Copy link
Collaborator Author

Min version 4.39s required for it. We are at 6.1

@imrannayer imrannayer merged commit 49b478a into terraform-google-modules:main Jan 24, 2025
4 checks passed
@release-please release-please bot mentioned this pull request Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-awmalik g-awmalik g-awmalik approved these changes

@isaurabhuttam isaurabhuttam Awaiting requested review from isaurabhuttam

@q2w q2w Awaiting requested review from q2w q2w is a code owner

Assignees

@imrannayer imrannayer

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@imrannayer @g-awmalik