Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create service account as part of instance template module #475

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Jan 23, 2025

No description provided.

@q2w q2w changed the title Main feat: create service account as part of instance template module Jan 23, 2025
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @q2w

modules/instance_template/variables.tf Outdated Show resolved Hide resolved
modules/instance_template/variables.tf Outdated Show resolved Hide resolved
examples/instance_template/simple_with_sa_creation/main.tf Outdated Show resolved Hide resolved
@q2w q2w force-pushed the main branch 8 times, most recently from 4eed6aa to 30c1913 Compare January 25, 2025 10:08
@q2w q2w force-pushed the main branch 2 times, most recently from 5abb7cd to adc7005 Compare January 25, 2025 14:08
@q2w q2w marked this pull request as ready for review January 25, 2025 15:39
@q2w q2w requested review from erlanderlo and a team as code owners January 25, 2025 15:40
modules/instance_template/variables.tf Outdated Show resolved Hide resolved
modules/instance_template/versions.tf Outdated Show resolved Hide resolved
@q2w q2w enabled auto-merge (squash) January 28, 2025 19:21
@q2w q2w merged commit bd21f7b into terraform-google-modules:main Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants