Expand allowable XS types to include lower case letters #2069
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
Allow lower case letters to be used as the XS type to increase the number of possible unique XS groups from 26 to 52.
Why is the change being made?
Some models have a large number of different XS types (15-20), and some internal plugins generate additional XS groups while running, which can push the total number of XS groups above 26. The ARMI app will currently crash if a 27th XS type is requested.
Notes
This should work fine on Linux or Mac platforms, which have case-sensitive filesystems. A user might encounter problems if they attempt to exceed 26 XS types on Windows, because the filesystem is not case-sensitive, and a plugin might try to generate a file name that is indistinguishable to a previous filename on Windows (e.g.,
latticePhysics-AA.inp
and thenlatticePhysics-aA.inp
). While this is unfortunate, the current code would also fail when a user tries to exceed 26 XS types (on any platform), so this PR isn't breaking a currently working capability, it's just changing the manner in which the code would fail.Checklist
doc
folder.pyproject.toml
.