Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand allowable XS types to include lower case letters #2069

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mgjarrett
Copy link
Contributor

What is the change?

Allow lower case letters to be used as the XS type to increase the number of possible unique XS groups from 26 to 52.

Why is the change being made?

Some models have a large number of different XS types (15-20), and some internal plugins generate additional XS groups while running, which can push the total number of XS groups above 26. The ARMI app will currently crash if a 27th XS type is requested.

Notes

This should work fine on Linux or Mac platforms, which have case-sensitive filesystems. A user might encounter problems if they attempt to exceed 26 XS types on Windows, because the filesystem is not case-sensitive, and a plugin might try to generate a file name that is indistinguishable to a previous filename on Windows (e.g., latticePhysics-AA.inp and then latticePhysics-aA.inp). While this is unfortunate, the current code would also fail when a user tries to exceed 26 XS types (on any platform), so this PR isn't breaking a currently working capability, it's just changing the manner in which the code would fail.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@mgjarrett mgjarrett self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant