-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reusable containers #757
feat: reusable containers #757
Conversation
…experimental` flag
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…containers.*` namespace
…/reusable-containers # Conflicts: # testcontainers/src/runners/async_runner.rs
…containers.*` namespace
…iners # Conflicts: # testcontainers/src/core/containers/request.rs # testcontainers/src/runners/async_runner.rs
@DDtKey Dug into the test failures, and it looks like it's just I updated the CI action to fix it, but (for obvious reasons) GHA won't run actions from forks / PR branches (usually). Not sure how to proceed here, got any thoughts? |
Actually, I think we can avoid usage of But regarding your question, CI works with your changes (if I got you correctly):
It fails on |
Fair enough. Removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all efforts! ❤️
I've left a few comments, please take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like what you've built here. Thank you a lot and sorry for all the delays 🙏
Only few minor comments and LGTM
Next milestones for this feature are:
- env-variable control
- proper reaper for "current session" (ryuk)
PR implements reusable containers inline with the existing reusable containers feature(s) of
testcontainers
for other languages.Important
This PR follows from (and is branched from) #756. PR 756 must be merged prior to merging this PR