Collectionbinder optimize sort #211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 19, 2015 08:27
…dicated container and for a container with some other static content.
…ent into account and don't move it to bottom each time
| }, this); | ||
| }; | ||
|
|
||
| var elements = _.chain(this._collection.models) |
There was a problem hiding this comment.
You could also use this._collection.chain(), which I think reads better and also allows for implementation changes on where models are stored in a collection in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further optimizations to the sorting algorithm in #210
This PR includes all changes form #210 and additionally introduces some sorting algorithm optimizations
The original algorithm calls $.children() on every iteration, which can be a time consuming operation.
The updated algorithm keeps track of element indexes in memory, so DOM calls are no longer required for defining the new position of an element in the current iteration.